-
Notifications
You must be signed in to change notification settings - Fork 38.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split NodeDiskPressure into NodeInodePressure and NodeDiskPressure #33218
Split NodeDiskPressure into NodeInodePressure and NodeDiskPressure #33218
Conversation
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
6b0692e
to
a6cecf1
Compare
CLAs look good, thanks! |
Jenkins GCE e2e failed for commit a6cecf1aae18973300c25760e66eb76c46537e17. The magic incantation to run this job again is |
a6cecf1
to
7420f46
Compare
fixed gofmt |
Reviewed 12 of 12 files at r1. pkg/kubelet/kubelet_node_status.go, line 725 [r1] (raw file):
nit: use pkg/kubelet/eviction/eviction_manager_test.go, line 919 [r1] (raw file):
You might want to assign this and related TODOs to yourself since you're owning this. pkg/kubelet/eviction/eviction_manager_test.go, line 946 [r1] (raw file):
ditto this one wrt owning TODOs pkg/kubelet/eviction/eviction_manager_test.go, line 1016 [r1] (raw file):
/s/disk/inode pkg/kubelet/eviction/eviction_manager_test.go, line 1018 [r1] (raw file):
/s/disk/inode pkg/kubelet/eviction/eviction_manager_test.go, line 1031 [r1] (raw file):
/s/disk/inode pkg/kubelet/eviction/eviction_manager_test.go, line 1033 [r1] (raw file):
/s/disk/inode pkg/kubelet/eviction/eviction_manager_test.go, line 1046 [r1] (raw file):
/s/disk/inode pkg/kubelet/eviction/eviction_manager_test.go, line 1048 [r1] (raw file):
/s/disk/inode pkg/kubelet/eviction/eviction_manager_test.go, line 1073 [r1] (raw file):
/s/disk/inode pkg/kubelet/eviction/eviction_manager_test.go, line 1083 [r1] (raw file):
/s/disk/inode pkg/kubelet/eviction/eviction_manager_test.go, line 1106 [r1] (raw file):
/s/disk/inode pkg/kubelet/eviction/eviction_manager_test.go, line 1108 [r1] (raw file):
/s/disk/inode pkg/kubelet/eviction/eviction_manager_test.go, line 1127 [r1] (raw file):
/s/disk/inode pkg/kubelet/eviction/eviction_manager_test.go, line 1129 [r1] (raw file):
/s/disk/inode plugin/pkg/scheduler/algorithm/predicates/predicates.go, line 1172 [r1] (raw file):
/s/CheckNodeDiskPressurePredicate/CheckNodeInodePressurePredicate plugin/pkg/scheduler/algorithm/predicates/predicates.go, line 1173 [r1] (raw file):
/s/disk/inode plugin/pkg/scheduler/algorithm/predicates/predicates_test.go, line 3050 [r1] (raw file):
Use plugin/pkg/scheduler/algorithm/predicates/predicates_test.go, line 3051 [r1] (raw file):
Use plugin/pkg/scheduler/algorithm/predicates/predicates_test.go, line 3062 [r1] (raw file):
Use plugin/pkg/scheduler/algorithm/predicates/predicates_test.go, line 3063 [r1] (raw file):
Use plugin/pkg/scheduler/algorithm/predicates/predicates_test.go, line 3079 [r1] (raw file):
Add something to the name to indicate that this is for inode pressure. plugin/pkg/scheduler/algorithm/predicates/predicates_test.go, line 3085 [r1] (raw file):
Add something to the name to indicate that this is for inode pressure. plugin/pkg/scheduler/algorithmprovider/defaults/defaults.go, line 155 [r1] (raw file):
/s/disk/inode Comments from Reviewable |
7420f46
to
bf554ce
Compare
Fixed |
Reviewed 4 of 4 files at r3. Comments from Reviewable |
@k8s-bot gke e2e test this |
bf554ce
to
da0a5ca
Compare
@k8s-bot unit test this issue #IGNORE |
@k8s-bot unit test this |
Jenkins unit/integration failed for commit da0a5cad40fba1de9757cdb274008a10025dc9e3. Full PR test history. The magic incantation to run this job again is |
I think this is the fix for the |
da0a5ca
to
0c8a664
Compare
issue: #33382 |
@k8s-bot gci gce e2e test this |
@k8s-bot gce e2e test this |
@k8s-bot kubemark gce e2e test this |
@k8s-bot kube gce e2e test this |
@k8s-bot test this issue #IGNORE |
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
Automatic merge from submit-queue |
Added NodeInodePressure as a NodeConditionType. SignalImageFsInodesFree and SignalNodeFsInodesFree signal this pressure. Also added simple pieces to the scheduler predicates so that it takes InodePressure into account.
This change is